Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generate an array view when an Array C++ type is requested #2335

Merged
merged 1 commit into from
Mar 22, 2023
Merged

fix: generate an array view when an Array C++ type is requested #2335

merged 1 commit into from
Mar 22, 2023

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Mar 22, 2023

No description provided.

@ianna ianna requested a review from jpivarski March 22, 2023 16:15
@ianna ianna temporarily deployed to docs-preview March 22, 2023 16:27 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #2335 (3d15759) into main (a9dd20a) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/highlevel.py 75.79% <0.00%> (-0.25%) ⬇️

jpivarski
jpivarski approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was pulled out of #2334 because we should let the docs PR wait until cppyy 3.0.1 is released and we want the bug-fix (separate from docs) to go in as soon as possible.

@ianna, has this passed local tests (with cppyy 3.0.1 installed on your comptuer)? If so, we can merge it. The strictness of actually testing it in CI will come when cppyy 3.0.1 is on PyPI.

@ianna
Copy link
Collaborator Author

ianna commented Mar 22, 2023

This was pulled out of #2334 because we should let the docs PR wait until cppyy 3.0.1 is released and we want the bug-fix (separate from docs) to go in as soon as possible.

@ianna, has this passed local tests (with cppyy 3.0.1 installed on your comptuer)? If so, we can merge it. The strictness of actually testing it in CI will come when cppyy 3.0.1 is on PyPI.

Yes, it does pass local tests.

@ianna ianna merged commit 8296580 into main Mar 22, 2023
@ianna ianna deleted the ianna/cppyy-awkward-git-bugfix branch March 22, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianna @jpivarski